As a code reviewer, I really dislike #github auto-merge feature. I often leave non-blocking comments but still approve the PR... which then gets merged automatically, without the author being able to read my comments.
Which means as a reviewer, I need either to hold my approve (â slow everything down + require me to come back at least once more on said PR even for non-blocking comments) OR to check before approving if the PR is in auto-merge mode or not and act accordingly âšī¸ annoying.
=> More informations about this toot | View the thread | More toots from pabuisson@ruby.social
=> View github tag This content has been proxied by September (3851b).Proxy Information
text/gemini