i sometimes think about the time i gave a code review and the guy switched teams after
my perspective was, paraphrased, in a nutshell: “the syntax you’ve landed on works. i see where you’re coming from and understand the code today, but wouldn’t want to maintain that approach tomorrow”
i only knew it was a problem after one of our other teammates was like “you should go talk to him in person” because our comments on the pr were getting long.
i still think using esoteric LESS syntax and multi layered nested object destructing could have been refactored more elegantly, otherwise the specifics of that pr wouldn’t be with me six years later.
optional chaining existed then with babel and i don’t fully remember the LESS code, other than i feel like he demonstrated turing completeness by accident
=> More informations about this toot | More toots from tychi@merveilles.town
text/gemini
This content has been proxied by September (ba2dc).