Ancestors

Toot

Written by the one girl in the cs class on 2025-01-21 at 19:58

if you do a pr and you get a review thingy back do you have to click 'resolve conversation' for each one.. like what does that do

actually wait how do you give them the changes they want, do you make a second pr??

=> More informations about this toot | More toots from kirakira@furry.engineer

Descendants

Written by linear cannon on 2025-01-21 at 19:59

@kirakira@furry.engineer you just make a commit and git push

=> More informations about this toot | More toots from linear@nya.social

Written by the one girl in the cs class on 2025-01-21 at 20:00

@linear ahh so pushing to the same branch in my fork that i pr'd?

=> More informations about this toot | More toots from kirakira@furry.engineer

Written by linear cannon on 2025-01-21 at 20:00

@kirakira@furry.engineer yep

=> More informations about this toot | More toots from linear@nya.social

Written by linear cannon on 2025-01-21 at 20:02

@kirakira@furry.engineer the "resolve" thing is just a signal to the reviewer (or whoever is looking) that you took action on that item, but in most forges usually if you modify the line it's on in your updated commit it will automatically mark it (i forget github's exact behavior)

=> More informations about this toot | More toots from linear@nya.social