Ancestors

Toot

Written by markus staab on 2024-11-30 at 14:05

need for #speed

[#]phpstan

fix was a one line change :-)

https://github.com/phpstan/phpstan-src/pull/3695

=> View attached media

=> More informations about this toot | More toots from markusstaab@phpc.social

Descendants

Written by dennistobar on 2024-11-30 at 15:39

@markusstaab Hi, do you think the speed problem is the hashing method or is it another reason? My question is because I am evaluating another code and I need to improve the speed of my code a little bit.

=> More informations about this toot | More toots from dennistobar@phpc.social

Written by markus staab on 2024-11-30 at 20:40

@dennistobar you never know if you don’t measure it.

I identified the bottleneck in https://github.com/phpstan/phpstan/issues/11968#issuecomment-2508942498 with a profiler

=> More informations about this toot | More toots from markusstaab@phpc.social

Written by dennistobar on 2024-11-30 at 20:43

@markusstaab Oh god, you're right... I forgot the first step of optimization: measuring and generating a baseline. Thanks for taking the time to respond, and yes, it seems a F1 in the measurements 😂

=> More informations about this toot | More toots from dennistobar@phpc.social