Ancestors

Written by Jens Axboe on 2024-09-12 at 18:18

Having worked on the kernel for decades, and imposing a lot of the same code/git hygiene for liburing, there can be a disconnect for contributors on what is expected of a commit and commit message, and what series of commits should look like. I attempted to provide a basic guideline here:

https://github.com/axboe/liburing/blob/master/CONTRIBUTING.md

and would appreciate feedback from folks on what I missed, what isn't clear, etc.

=> More informations about this toot | More toots from axboe@fosstodon.org

Written by Mathieu on 2024-09-12 at 20:30

@axboe Looks good. I'm from a kernel background so all looks pretty standard / expected so maybe I'm not really the target audience, but looks good never the less.

=> More informations about this toot | More toots from mathieu@fosstodon.org

Written by Jens Axboe on 2024-09-12 at 20:31

@mathieu as someone else said, "it's common sense!". But I think not if you haven't been through the ringer already. Thanks for reading!

=> More informations about this toot | More toots from axboe@fosstodon.org

Toot

Written by Mathieu on 2024-09-12 at 20:32

@axboe Yeah I had the same feeling initially reading it, then I remembered all the PRs etc I went through in python land (for $DAYJOB) and realised well... maybe it's really not that common for other people out there on GH and elsewhere.

=> More informations about this toot | More toots from mathieu@fosstodon.org

Descendants